search

maxmind / geoipupdate-legacy

GeoIP update client code
GNU General Public License v2.0
258 stars 63 forks source link

Protocol docs in `GeoIP.conf` are confusing #23

Closed chicks-net closed 9 years ago

chicks-net commented 9 years ago

In GeoIP.conf https://github.com/maxmind/geoipupdate/blob/master/conf/GeoIP.conf.default#L19 it says:

# The desired protocol either "https" (default) or "https".

It is saying https twice. So it is not clear whether http or https is actually the default. Presumably one of those should not include the s but even reading the source code does not make it clear which s should be removed to me.

oschwald commented 9 years ago

Thanks!

chicks-net commented 9 years ago

Awesome speed! :rocket:

Where does the default of https come from?

oschwald commented 9 years ago

Here. You can verify that it is set correctly by running it with the -v option.

chicks-net commented 9 years ago

Awesome @oschwald thanks