search

maxmind / geoipupdate-legacy

GeoIP update client code
GNU General Public License v2.0
258 stars 63 forks source link

Use OpenSSL's MD5-implementation instead of our own #69

Closed UnitedMarsupials-zz closed 7 years ago

UnitedMarsupials-zz commented 7 years ago

The rationale is simple -- libcurl, which is already a requirement, typically links with OpenSSL. Let's use OpenSSL's MD5-implementation instead of maintaining our own implementation.

Some people build curl with NSS instead of OpenSSL (or derivative), so it might be better to go through the curl_md5.h compatibility layer instead. Unfortunately, the header is not installed by the FreeBSD-port of the library.

This makes it less straightforward than my earlier PR #68, but it is still worth considering.

oschwald commented 7 years ago

This might be relevant to getting the macOS builds to work: https://github.com/travis-ci/travis-ci/issues/6698

UnitedMarsupials-zz commented 7 years ago

Yes, this was just an illustration, really -- and I used #defines to reduce the differences. Point is, there are so many MD5-implementations out there already, there is no justification in bringing in yet another :)