maxmind / libmaxminddb

C library for the MaxMind DB file format
https://maxmind.github.io/libmaxminddb/
Apache License 2.0
912 stars 239 forks source link

new minor release with the recent CMake fixes #263

Closed fcelda closed 3 years ago

fcelda commented 3 years ago

Please, would it be possible to release a new version of libmaxminddb to include the recent CMake fixes?

I'm finishing the libmaxminddb package for Conan. I was asked by one of the reviewers if you would consider cutting a new release so that we could remove the patches from Conan. It's mainly to make the package recipe clean.

No worries if you can't or don't want to do that yet.

oschwald commented 3 years ago

I did a 1.6.0 release. Thanks!

fcelda commented 3 years ago

Thank you, Gregory! :bowing_man:

mcauto commented 3 years ago

it is not working.

@oschwald could you help me?

I get an error below.

CMake Error at source_subfolder/CMakeLists.txt:74 (install):
  install TARGETS given no ARCHIVE DESTINATION for static library target
  "maxminddb"

https://github.com/maxmind/libmaxminddb/blob/main/CMakeLists.txt#L74

cmake, conanfile.py ```cmake CMAKE_MINIMUM_REQUIRED (VERSION 2.8) PROJECT ( reference ) FIND_PACKAGE ( PythonInterp ) IF ( NOT EXISTS "${CMAKE_BINARY_DIR}/conan.cmake" ) MESSAGE ( STATUS "Downloading conan.cmake from https://github.com/conan-io/cmake-conan" ) FILE ( DOWNLOAD "https://raw.githubusercontent.com/conan-io/cmake-conan/master/conan.cmake" "${CMAKE_BINARY_DIR}/conan.cmake") ENDIF () INCLUDE ( ${CMAKE_BINARY_DIR}/conan.cmake ) conan_cmake_run ( CONANFILE conanfile.py BUILD missing BUILD_TYPE Release VERBOSE) conan_basic_setup ( TARGETS NO_OUTPUT_DIRS ) INCLUDE_DIRECTORIES ( ${CONAN_INCLUDE_DIRS} ) ENABLE_TESTING() ``` ```python # conanfile.py from conans import ConanFile class MylibConan(ConanFile): setting = "os", "compiler", "build_type", "arch" requires = (("zlib/1.2.11"),\ ("openssl/1.1.1k"),\ ("gtest/1.8.1"),\ ("benchmark/1.5.3"),\ ("libcurl/7.77.0"),\ ("libmaxminddb/1.6.0"), ("hiredis/0.14.1")) generators = "cmake" option = {"libcurl:fPIC" : True,\ "libcurl:with_openssl": True,\ "libmaxminddb:shared": False } def imports(self): self.copy("license*", dst="licenses", folder=True, ignore_case=True) ```