maxmind / libmaxminddb

C library for the MaxMind DB file format
https://maxmind.github.io/libmaxminddb/
Apache License 2.0
912 stars 239 forks source link

Define SSIZE_MAX conditionally? #338

Closed voegelas closed 9 months ago

voegelas commented 9 months ago

I get the following warning if libmaxminddb is built with the C compiler from Strawberry Perl.

libtool: compile:  gcc -DHAVE_CONFIG_H -I. -I.. -I../include -I../include -O2 -g -g -fms-extensions -MT maxminddb.lo -MD -MP -MF .deps/maxminddb.Tpo -c maxminddb.c -o maxminddb.o
maxminddb.c:26: warning: "SSIZE_MAX" redefined
 #define SSIZE_MAX INTPTR_MAX

In file included from c:/strawberry/c/lib/gcc/x86_64-w64-mingw32/8.3.0/include-fixed/limits.h:194,
                 from c:/strawberry/c/lib/gcc/x86_64-w64-mingw32/8.3.0/include-fixed/syslimits.h:7,
                 from c:/strawberry/c/lib/gcc/x86_64-w64-mingw32/8.3.0/include-fixed/limits.h:34,
                 from c:/strawberry/c/x86_64-w64-mingw32/include/stdlib.h:10,
                 [...]
                 from c:/strawberry/c/x86_64-w64-mingw32/include/windows.h:69,
                 from c:/strawberry/c/x86_64-w64-mingw32/include/winsock2.h:23,
                 from ../include/maxminddb.h:16,
                 from data-pool.h:4,
                 from maxminddb.c:8:
c:/strawberry/c/x86_64-w64-mingw32/include/limits.h:84: note: this is the location of the previous definition
 #define SSIZE_MAX _I64_MAX
oschwald commented 9 months ago

Thanks for the report. 1.9.1 was released with a fix.