search

maxmind / minfraud-api-python

Python API for minFraud Score, Insights, and Factors
https://minfraud.readthedocs.org/
Apache License 2.0
27 stars 12 forks source link

Tuple annotations #60

Closed arnimarj closed 4 years ago

arnimarj commented 4 years ago

Hi,

Its wonderful to see the new annotation support. I'd just like to point out a small issue with some Tuple annotations in https://github.com/maxmind/minfraud-api-python/blob/master/minfraud/models.py

Annotations for Tuple of arbitrary length should be Tuple[SomeType, ...] instead of Tuple[SomeType]. The latter matches only a tuple of length 1, where the former supports Tuples of any length.

I found 6 instances of Tuple[str] in https://github.com/maxmind/minfraud-api-python/blob/master/minfraud/webservice.py

oschwald commented 4 years ago

Thanks! This was fixed in 2.0.2.