maxmx / bootstrap-stylus

Port of Bootstrap to Stylus
MIT License
585 stars 113 forks source link

Adding jshint task to fix possible errors shown in the console output, better indentation of js code and update the grunt-contrib-stylus dependence #118

Closed ghost closed 8 years ago

Blackskyliner commented 8 years ago

Just my opinion on this, I would have split this in at least 3 commits. One changing the CodeStyle on all current files and one adding jshint as dependency and one updating the grunt-contrib dependency, to be more atomic and also to better "see" what was done. (This would also keep the commit messages somewhat smaller) It would also make later reasoning about changes somewhat more pleasant.

maxmx commented 8 years ago

Too large to merge and not worthwhile to do for BS3.

Also I much prefer eslint, might include it in BS4 stylus.

ghost commented 8 years ago

Thanks for the tips @Blackskyliner and @maxmx, with the upcoming release of the BS4 is not feasible to merge, I did not know ESLint is even better.