Adds support for use as Stylus plugin with directory namespacing

maxmx / bootstrap-stylus

Port of Bootstrap to Stylus

MIT License

585 stars 113 forks source link

Adds support for use as Stylus plugin with directory namespacing #82

Closed chasevida closed 9 years ago

chasevida commented 9 years ago

This pull request is based mainly on comments and additions suggested in #72 .

The highlights are:

Stylus plugin support as added by @eafzali
Updates the directory structure to add some sort of namespacing to avoid import conflicts as mentioned by @Aaike
Instructions on downloading via npm and basic usage within the read me
Updated package information specifically keywords, github url and description

I've run basic tests scenarios and they seem to pass. Obviously this pull request has been made before there was a consensus on renaming the directories but I needed this functionality now so I've implemented it in a fork. It would be preferable if this was in the main repo.

Feedback welcome.

Aaike commented 9 years ago

Nice, i like this setup. One more thing i would add or change is to have an index.styl in the bootstrap directory.

right now you would have to do this to pull in bootstrap :

@import bootstrap/bootstrap

by copying the bootstrap.styl to index.styl , you would be able to do just this :

@import bootstrap

the index.styl is then included automatically

chasevida commented 9 years ago

Yup fair enough, I meant to do that but was in a super rush. @eafzali has just implemented that in his pull request and since he was in first I think it courteous to close this one and for his to be finalised and accepted.

I just think his needs to update the gruntfile.js and the package.json and we're good to go.