search

maxmx / bootstrap-stylus

Port of Bootstrap to Stylus
MIT License
585 stars 113 forks source link

Navbar bug #85

Closed hugofabricio closed 9 years ago

hugofabricio commented 9 years ago

Hi,

The navbar is with bug in Mobile when you put navbar-right

morenoh149 commented 9 years ago

provide a code snippit or demo

kane-c commented 9 years ago

Which browser and version? If you could please provide some code or a live sample that would be helpful.

I've been using navbar-right quite often and haven't run into any issues yet.

hugofabricio commented 9 years ago

I tested it on Safari, Chrome and Firefox.

morenoh149 commented 9 years ago

@hugofabricio whats the bug exactly?

hugofabricio commented 9 years ago

When we use the navbar-right class in responsive menu it is not 100%.

morenoh149 commented 9 years ago

@hugofabricio you want to make the text justified right. Not the entire drop-down. Try http://devdocs.io/css/text-align Right

maxmx commented 9 years ago

I think he's saying that the drop down menu should be the same width as the viewport. Floated element have to set their widths explicitly, may be a bug.

If you do a fix, please open a PR.

hugofabricio commented 9 years ago

That's right, sorry for my English, I'm not using the bootstrap text-right, I'm just stating that the menu by the cell is not 100% as is the right to the bootstrap.

Menu correct

kane-c commented 9 years ago

Could you please post the HTML for your navbar?

hugofabricio commented 9 years ago 
        <nav class="navbar navbar-default">
            <div class="container">
                <div class="navbar-header">
                    <button type="button" class="navbar-toggle collapsed" data-toggle="collapse" data-target="#menu">
                        <span class="sr-only">Menu</span>
                        <span class="icon-bar"></span>
                        <span class="icon-bar"></span>
                        <span class="icon-bar"></span>
                    </button>
                    <a class="navbar-brand" href="#">Brand</a>
                </div>
                <div class="collapse navbar-collapse" id="menu">
                    <ul class="nav navbar-nav navbar-right">
                        <li class="active"><a href="index.html">Home</a></li>
                        <li><a href="about.html">Quem Somos</a></li>
                        <li><a href="buildings.html">Imóveis</a></li>
                        <li><a href="sales.html">Venda Conosco</a></li>
                        <li><a href="contact.html">Contato</a></li>
                    </ul>
                </div>
            </div>
        </nav>
kane-c commented 9 years ago

I believe this is fixed in #89. Specifically these changes to .navbar-left and .navbar-right