search

maxmx / bootstrap-stylus

Port of Bootstrap to Stylus
MIT License
585 stars 113 forks source link

better borders on tabs #98

Closed stdavis closed 8 years ago

stdavis commented 9 years ago

I was having trouble with my tabs having border radius applied to the bottom corners. For example: image

After switching to the border-top-radius mixin the problem was resolved. image

kane-c commented 9 years ago

Which version of Stylus are you using?

Mine compiles like this (v0.51.1)

.nav-tabs > li > a {
  margin-right: 2px;
  line-height: 1.428571429;
  border: 1px solid transparent;
  border-radius: 4px 4px 0 0;
}
kane-c commented 9 years ago

I just tried a few different versions of Stylus and it seems to work ok from v0.47.0 onwards (didn't try every patch version though) and it's working as expected.

Are you using anything else besides Bootstrap that might be interfering (e.g. defining its own border-radius mixin?

stdavis commented 9 years ago

I'm using it via grunt-contrib-stylus and it looks like I'm on v0.49.3. Not sure what other stuff I have that's may be interfering. Good to know that it's work appropriately for you. I'm sure there's something up with my situation.

This still seems like a cleaner way to go IMO but no big deal to me either way. Thanks for the great project.