search

maxnegro / joplin-plugin-admonition

Joplin markdown plugin for custom containers
37 stars 4 forks source link

Does not render admonition with themes #2

Closed jsantos74 closed 2 years ago

jsantos74 commented 3 years ago

If you use the light them it works OK. image image

But if you use the Dark theme image image

Joplin 2.1.7 (prod, linux) Client ID: ac59218bf3454049b9bfb0a2f478dcfc Sync Version: 2 Profile Version: 39 Keychain Supported: No Revision: 04c4015

robertoszek commented 3 years ago

For now I just manually edited this line on the markdownit-admonition.css file on the .jpl archive: https://github.com/maxnegro/joplin-plugin-admonition/blob/7083d34096a8fff31a1b3b401f27cc1fc5653569/src/markdownit-admonition.css#L2 to

  background-color: transparent;

and reinstalled the plugin with the modified .jpl file.

Good enough for me and the dark theme I'm using.

maxnegro commented 2 years ago 
  background-color: transparent;

Nice catch. I'll add it to next release, in a week or so.