maxnet / berryboot

Berryboot -- Boot menu / OS installer
http://www.berryboot.com/
Other
799 stars 135 forks source link

Missing mksquashfs does not stop the build process #693

Closed owl770 closed 3 years ago

owl770 commented 3 years ago

I didn't realise but on one of my RPi's I had not installed squashfs-tools, so mksquashfs was not available. This meant that berryboot/external/package/berrybootgui2/post-build.sh failed with the following message:

>>>   Executing post-build script /mnt2/test/berryboot/external/package/berrybootgui2//post-build.sh
Making shared.img with modules
/mnt2/test/berryboot/external/package/berrybootgui2//post-build.sh: 11: /mnt2/test/berryboot/external/package/berrybootgui2//post-build.sh: mksquashfs: not found

But the build script continued and appeared to complete successfully (there was a message about not being able to copy shared.img to the output directory but it took me ages to figure out why). I installed squashfs-tools and then the build completed properly.

Is the correct fix for this problem to include set -e at the top of berryboot/external/package/berrybootgui2/post-build.sh or should it be fixed some other way?