search

maxnowack / homebridge-eq3ble

Homebridge plugin to control EQ3 bluetooth thermostats
GNU General Public License v3.0
21 stars 8 forks source link

re-discover thermostat on failures #3

Closed aleksandrsivanovs closed 7 years ago

aleksandrsivanovs commented 7 years ago

I would like to propose two improvements for this plugin.

both of described things are coming from personal experience setting up the thermostat and homebridge on rpi2.

  1. sometimes homebridge can't connect to the device and then it can't reconnect until I restart the homebridge. It means that if connection to the device timed out - then there is possibility that device went off the grid - i.e., it shouldn't be discoverable - i.e. we need to re-run discover

  2. sometimes I start homebridge too early - much earlier than the thermostat boots up and finishes all it's adoptions. in this case homebridge won't pick up this thermostat when it will be ready - it will just stay as non-working device. It means that if discover failed in constructor - then we shouldn't block all further work with this thermostat - we need to retry discover on next request

maxnowack commented 7 years ago

Thank you for the PR! 👍

maxnowack commented 7 years ago

I've released it in v1.2.1

aleksandrsivanovs commented 7 years ago

thank you :)