maxnowack / node-podcast

Podcast feed generator for Node.
MIT License
157 stars 39 forks source link

Change iTunes explicit tag to be 'yes', 'no', or 'clean' #46

Closed audrow closed 2 years ago

audrow commented 2 years ago

Hey thanks for making this. It really makes it easier to generate a podcast RSS feed.

One thing that I notice when I use the W3C feed validator (https://validator.w3.org/feed/) on the built XML is that the validator doesn't like true or false for the itunes:explicit tag. It would be nice if instead of a boolean, we could pass 'yes' | 'no' | 'clean', as suggested by the feed validator. Alternatively, the bool could be turned into 'yes' or 'no'.

Screen Shot 2022-01-03 at 9 20 00 AM

For now, I'm using the following work around to get my feed validated.

const podcast = new Podcast(feedOptions)
// ...add items for episodes...
const rssXml = podcast
  .buildXml()
  .replace(/<itunes:explicit>false<\/itunes:explicit>/g, '<itunes:explicit>no</itunes:explicit>')
  .replace(/<itunes:explicit>true<\/itunes:explicit>/g, '<itunes:explicit>yes</itunes:explicit>')
JumpLink commented 2 years ago

Okay so #41 was wrong..

toshi-toma commented 2 years ago

Hi @JumpLink Do you have plan to release the #51 ?

JumpLink commented 2 years ago

@toshi-toma yes and done :)

toshi-toma commented 2 years ago

@JumpLink

Thank you :)