search

maxolasersquad / orthosie

Point of sale system written in Python
GNU General Public License v3.0
87 stars 49 forks source link

Django1.10 #31

Closed eracle closed 8 years ago

eracle commented 8 years ago

Django 1.10 upgraded

maxolasersquad commented 8 years ago

All of these changes look good, and I really appreciate you taking the time to do this.

Before I merge this in, are these changes backwards compatible to Django 1.8? I'm wondering if we shouldn't just bump the requirements up to 1.10.

eracle commented 8 years ago

No, as I just tried, with django 1.8 it tries to load the static files from a different directory, this is the runserver log ( the 404 responses are the errors):

[16/Sep/2016 09:02:36]"GET /register/ HTTP/1.1" 200 6596 [16/Sep/2016 09:02:36]"GET /static/js/require.js HTTP/1.1" 304 0 [16/Sep/2016 09:02:36]"GET /static/register/css/register.css HTTP/1.1" 304 0 [16/Sep/2016 09:02:36]"GET /css/bootstrap.min.css HTTP/1.1" 404 18633 [16/Sep/2016 09:02:36]"GET /css/font-awesome.css HTTP/1.1" 404 18630 [16/Sep/2016 09:02:36]"GET /css/bootstrap-theme.min.css HTTP/1.1" 404 18651 [16/Sep/2016 09:02:36]"GET /static/register/js/register.js HTTP/1.1" 304 0

I would propose to bump the requirements to 1.10

maxolasersquad commented 8 years ago

If you don't mind adding the version bump and then I'll merge this in.

eracle commented 8 years ago

done