search

maxonrow / docs

Maxonrow Documents
0 stars 1 forks source link

Maxonrow Blockchain v1.0 - NFTs module contents enhancements #2

Open githubckgoh1439 opened 4 years ago

githubckgoh1439 commented 4 years ago

Request Date/time : 27-May-2020

Details Request :

  1. Item of MsgTypeSetNonFungibleTokenStatus : Request details info on Token Data Information

  2. Item of MsgTypeSetNonFungibleItemStatus : Request details info on Item Details Information

  3. Item of MsgTypeEndorsement : about the MEMO usage

  4. Tab navigator : about the navigation of user experience

githubckgoh1439 commented 4 years ago

Dear all,

Due to still under POC stage (work in progress) of the current documentation, please refer to :

https://github.com/githubckgoh1439/docs/tree/master

githubckgoh1439 commented 4 years ago

@yk,

I already updated base on THREE items above. For the item-4, I still in progress and update later once completed.

Please review and comments.

yk commented 4 years ago

wrong user :)

b00f commented 4 years ago

@yk Please check them. It doesn't take time. You can check these commits: https://github.com/githubckgoh1439/docs/commit/c4af45556e7514aa5f4f2b45ef4ff200034f6423 https://github.com/githubckgoh1439/docs/commit/fa4dde4eaa1e9f0e3a633b87fb988d6d6815fab6

yk commented 4 years ago

I'm not the person you meant to tag

b00f commented 4 years ago

@yk So sorry. That is bad of me. ;)

@yenkhoon Please take a look at @githubckgoh1439 commits.

githubckgoh1439 commented 4 years ago

Hi, @yenkhoon

I changed a bit on the NFTs contents themes to suit the navigation features in the sidebar, as whole contents in one page.

U can check and comments later.

yenkhoon commented 4 years ago

hi goh, appreciate your good work. However there are few things could be tune to better.

The details,

remove the word behind all details and make it a title "Details"

status details -> Status in this section you need to explain the available options(status) in one table. Or leave it as it is and make the status bold.

transferLimit details need to add in the expectation input, we are expecting number string here. Also upon approved, it coundt be updated anymore.

mintLimit details this need to explain we are expecting number string not other string. also need to add in the expectation input, we are expecting number string here. Also upon approved, it coundt be updated anymore.

burnable details burnable flag is not update able after token has been approve also. this is wrong u mention freeze and unfreeze.

transferable details please mention is not update able after approve.

modifiable details we are talking about token but u mention item here. token has it own metadata as well. please correct it.

pub details it is confusing to use signer here, can u please use minter instead? When pub flag set to true, anyone can mint the token item, but they can only mint to themselves.

if it is false, then the minter has to be the token owner.

tokenFees details please mention this is compulsory upon approving token. And the token fees setting name can get from where? we have a link in core please link them.

endorserList details For the public equals TRUE, system will do verification on the current signer whether come from the endorser list during Item Endorsement process. If not, with an alert of 'Invalid endorser'. Howevere if endorser list is set to empty, system will not do this validation during endorsement-item process. Prior to this, this endorser list will be set as one of the token flag components during approve-token.

this is wrong, endorserlist do not affect by the public flag. Endorser list is there if the token approved and it has endorser list, then the token's item can be endorsed by the wallet which inside the endorser list only. And in this field we are expecting wallet address. If the endorser list is empty, then anyone can endorse.

yenkhoon commented 4 years ago

@githubckgoh1439

githubckgoh1439 commented 4 years ago

Hi, YK

Will follow up as above commented. TQ.

On Tue, Jun 2, 2020 at 9:00 AM yk notifications@github.com wrote:

hi goh, appreciate your good work. However there are few things could be tune to better.

The details,

remove the word behind all details and make it a title "Details"

status details -> Status in this section you need to explain the available options(status) in one table. Or leave it as it is and make the status bold.

transferLimit details need to add in the expectation input, we are expecting number string here. Also upon approved, it coundt be updated anymore.

mintLimit details this need to explain we are expecting number string not other string. also need to add in the expectation input, we are expecting number string here. Also upon approved, it coundt be updated anymore.

burnable details burnable flag is not update able after token has been approve also. this is wrong u mention freeze and unfreeze.

transferable details please mention is not update able after approve.

modifiable details we are talking about token but u mention item here. token has it own metadata as well. please correct it.

pub details it is confusing to use signer here, can u please use minter instead? When pub flag set to true, anyone can mint the token item, but they can only mint to themselves.

if it is false, then the minter has to be the token owner.

tokenFees details please mention this is compulsory upon approving token. And the token fees setting name can get from where? we have a link in core please link them.

endorserList details For the public equals TRUE, system will do verification on the current signer whether come from the endorser list during Item Endorsement process. If not, with an alert of 'Invalid endorser'. Howevere if endorser list is set to empty, system will not do this validation during endorsement-item process. Prior to this, this endorser list will be set as one of the token flag components during approve-token.

this is wrong, endorserlist do not affect by the public flag. Endorser list is there if the token approved and it has endorser list, then the token's item can be endorsed by the wallet which inside the endorser list only. And in this field we are expecting wallet address. If the endorser list is empty, then anyone can endorse.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/maxonrow/docs/issues/2#issuecomment-637205754, or unsubscribe https://github.com/notifications/unsubscribe-auth/AIQPD6ENHQVV2WGGYQTN3STRURFJVANCNFSM4NOSPRVA .

githubckgoh1439 commented 4 years ago

hi goh, appreciate your good work. However there are few things could be tune to better.

The details,

remove the word behind all details and make it a title "Details"

status details -> Status in this section you need to explain the available options(status) in one table. Or leave it as it is and make the status bold.

transferLimit details need to add in the expectation input, we are expecting number string here. Also upon approved, it coundt be updated anymore.

mintLimit details this need to explain we are expecting number string not other string. also need to add in the expectation input, we are expecting number string here. Also upon approved, it coundt be updated anymore.

burnable details burnable flag is not update able after token has been approve also. this is wrong u mention freeze and unfreeze.

transferable details please mention is not update able after approve.

modifiable details we are talking about token but u mention item here. token has it own metadata as well. please correct it.

pub details it is confusing to use signer here, can u please use minter instead? When pub flag set to true, anyone can mint the token item, but they can only mint to themselves.

if it is false, then the minter has to be the token owner.

tokenFees details please mention this is compulsory upon approving token. And the token fees setting name can get from where? we have a link in core please link them.

endorserList details For the public equals TRUE, system will do verification on the current signer whether come from the endorser list during Item Endorsement process. If not, with an alert of 'Invalid endorser'. Howevere if endorser list is set to empty, system will not do this validation during endorsement-item process. Prior to this, this endorser list will be set as one of the token flag components during approve-token.

this is wrong, endorserlist do not affect by the public flag. Endorser list is there if the token approved and it has endorser list, then the token's item can be endorsed by the wallet which inside the endorser list only. And in this field we are expecting wallet address. If the endorser list is empty, then anyone can endorse.

Goh question : 

Item : modifiable details

I already double checked this. This modifiable only applied for the 'UpdateItemMetadata' & not for the 'UpdateNFTMetadata'.
So this not applicable to Token metadata updating. Am I Correct ? 
Item : tokenFees details

Is that link with this : 'GetTokenFeeSetting' in Fee Setting Module ?
githubckgoh1439 commented 4 years ago

@yenkhoon

Please comments my question above.

yenkhoon commented 4 years ago

fee setting name in testnet https://alloys-rpc.maxonrow.com/debug/fee_info?

yeap you are right.

githubckgoh1439 commented 4 years ago

YK,

Noted and will follow up this.

On Tue, Jun 2, 2020 at 1:31 PM yk notifications@github.com wrote:

fee setting name in testnet https://alloys-rpc.maxonrow.com/debug/fee_info?

yeap you are right.

— You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub https://github.com/maxonrow/docs/issues/2#issuecomment-637286529, or unsubscribe https://github.com/notifications/unsubscribe-auth/AIQPD6CLZ4JLRCB2AFWHOZTRUSFBJANCNFSM4NOSPRVA .

githubckgoh1439 commented 4 years ago

@yenkhoon

I updated the document of NFTs. pls check.

https://maxonrow-docs.readthedocs.io/en/latest/modules/nonfungible/nonfungible.html

yenkhoon commented 4 years ago

hi goh, the navigation looks good and you haven tell them that they need authorised address, issuer and provider to do approving, freeze, unfreeze and reject. You just told them authorised, they will not understand.

githubckgoh1439 commented 4 years ago

YK,

Noted and will update accordingly. Later update.

On Thu, Jun 4, 2020 at 9:40 AM yk notifications@github.com wrote:

hi goh, the navigation looks good and you haven tell them that they need authorised address, issuer and provider to do approving, freeze, unfreeze and reject. You just told them authorised, they will not understand.

— You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub https://github.com/maxonrow/docs/issues/2#issuecomment-638550195, or unsubscribe https://github.com/notifications/unsubscribe-auth/AIQPD6G2HCWMBPGYDNYROK3RU33RBANCNFSM4NOSPRVA .

githubckgoh1439 commented 4 years ago

hi goh, the navigation looks good and you haven tell them that they need authorised address, issuer and provider to do approving, freeze, unfreeze and reject. You just told them authorised, they will not understand.

YK,

I fixed them. Please check later:

https://maxonrow-docs.readthedocs.io/en/latest/modules/nonfungible/nonfungible.html

yenkhoon commented 4 years ago

@githubckgoh1439 let me know if you updated anything. The most important thing are the description. Just write straight to the point, especially the status and details.

githubckgoh1439 commented 4 years ago

YK,

I simplified the contents on this:

  1. https://maxonrow-docs.readthedocs.io/en/latest/modules/fungible/fungible.html
  2. https://maxonrow-docs.readthedocs.io/en/latest/modules/nonfungible/nonfungible.html

base on this commit in my git: -- https://github.com/githubckgoh1439/docs/commit/e3831824e47147ce61973cb5c50539a016df9e49

Please comments.

yenkhoon commented 4 years ago

you haven modify this sentence, "A valid new token which yet to be approved must be signed by authorised KYC Signer with valid signature will be proceed along with a valid Fee setting scheme that been provided. Token which already been approved is not allowed to do re-submit." <- i don't understand what is this.

githubckgoh1439 commented 4 years ago

YK,

Will follow up on this and update.

On Tue, Jul 28, 2020 at 9:27 AM yk notifications@github.com wrote:

you haven modify this sentence, "A valid new token which yet to be approved must be signed by authorised KYC Signer with valid signature will be proceed along with a valid Fee setting scheme that been provided. Token which already been approved is not allowed to do re-submit." <- i don't understand what is this.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/maxonrow/docs/issues/2#issuecomment-664722656, or unsubscribe https://github.com/notifications/unsubscribe-auth/AIQPD6H7AZJY3NVVNAELRH3R5YSPPANCNFSM4NOSPRVA .

githubckgoh1439 commented 4 years ago

YK,

I updated these:

https://maxonrow-docs.readthedocs.io/en/latest/modules/fungible/fungible.html https://maxonrow-docs.readthedocs.io/en/latest/modules/nonfungible/nonfungible.html

base on this commit in my git: -- https://github.com/githubckgoh1439/docs/commit/373f98e69815725b7dc015775fbc736285c2c200

githubckgoh1439 commented 4 years ago

YK,

I updated:

https://maxonrow-docs.readthedocs.io/en/latest/modules/fungible/fungible.html

https://maxonrow-docs.readthedocs.io/en/latest/modules/nonfungible/nonfungible.html