search

maxonrow / maxonrow-go

Maxonrow Blockchain
https://www.maxonrow.com/
5 stars 6 forks source link

Broadcasting internal transaction when rpc is disabled #39

Closed b00f closed 4 years ago

b00f commented 4 years ago

Currently multi-sig broadcast internal transaction via rpc. What happens if RPC is disabled? We need to find a way to not use RPC for broadcasting transaction.

yenkhoon commented 4 years ago

our rpc cant be disabled anyway. Some portion of the ante.go require it to retrieve chain-id and block number.

it is sending locally, I believe there is no concern even the 26657 ports is using a localhost. However if it is disabled, then some portion of our code in ante.go wouldn't run as well. So in conclusion, our rpc can't be disabled.

yenkhoon commented 4 years ago

this is the line 213 in ante.go:

res, err := rpc.Block(nil, &num)

yenkhoon commented 4 years ago

can we close this issue?

b00f commented 4 years ago

Did we test it when the rpc is closed?

yenkhoon commented 4 years ago

closing this issue.