search

maxonrow / maxonrow-go

Maxonrow Blockchain
https://www.maxonrow.com/
5 stars 6 forks source link

MultiSig - Latest Test-cases for NFTs modules #97

Closed githubckgoh1439 closed 4 years ago

githubckgoh1439 commented 4 years ago

Hi, Mostafa

I added new test-cases for NFTs. Please review and comments.

TQ.

githubckgoh1439 commented 4 years ago

Hi, Mostafa

Will follow up those you commented above.

TQ.

githubckgoh1439 commented 4 years ago

Hi, Mostafa

This my testing-result & finding base on your comments :

Below with Test-cases that need the 5 seconds waiting-period

Pair-1 :

1. Action - Create MultiSig Tx for NFTs [Create-token]
2. Action - APPROVE NFTs token
-- If the above action Multisig-Create-Token not set-to-wait-5-seconds, this will have Error of 'Can not find this particular token-symbol'

Pair-2 :

3. Action - Create MultiSig Tx for NFTs [Mint-item]
4. Action - ENDORSE NFTs item 
-- If the above action Multisig-Mint-Item not set-to-wait-5-seconds, this will have Error of 'Code 2006 -Invalid token.'

Pair-3 :

5. Action - Create MultiSig Tx for NFTs [Transfer-token-ownership]
6. Action - VERIFY NFTs token transfer ownership 
-- If the above action Multisig-Transfer-token-ownership not set-to-wait-5-seconds, this will have Error of 'Code 2104 - Verify transfer token ownership invalid'

Remarks :

1. [APPROVE nonfungible token] : Is refer to your 'approve_create_token'
2. [VERIFY nonfungible token transfer ownership] : Is refer to your 'approve_transfer_ownership'

Please comments.

githubckgoh1439 commented 4 years ago

The case we discussed today is included?

Mostafa,

I already updated test-cases base on last-week DEMO discussion under this commit:

https://github.com/maxonrow/maxonrow-go/pull/97/commits/ac7a4232aa519dfcdc0152476399ff53be30f24b

, which include: case-2.1.1 case-2.1.2 case-2.1.3

yenkhoon commented 4 years ago

goh u might wanna enable back the test case before merging? anyway it looks good though thanks!

githubckgoh1439 commented 4 years ago

Hi, Mostafa & YK

I will commit the latest test-cases for NFTs-multisig by today evening, before I come out the request for review and merging.

TQ.