FSGuess: 0xE9 is also a valid jump instruction

maxpat78 / FATtools

Facilities to access (ex)FAT filesystems and disk images with Python 3

39 stars 4 forks source link

Closed gavanderhoorn closed 3 years ago

gavanderhoorn commented 3 years ago

As per subject.

0xE9 is also allowed in the jump instruction part of a boot record. See Design of the FAT file system: Reserved sectors area: Boot Sector for instance.

I had a view images which FATtools failed to open as it only checked for 0xEB.

After making this change, they all opened successfully.

maxpat78 commented 3 years ago

Ok, fixed. Thx! I didn't check x86 manual, only looked at common boot sectors.

gavanderhoorn commented 3 years ago

Was the code contributed in this PR not correct?

maxpat78 commented 3 years ago

Obviously it was correct, but I've read the mail and directly fixed it in my local repo before going online :D Happy coding!