search

maxpumperla / ScalphaGoZero

An independent implementation of DeepMind's AlphaGoZero in Scala, using Deeplearning4J (DL4J)
Apache License 2.0
156 stars 24 forks source link

`Move` could be an ADT #4

Closed guizmaii closed 6 years ago

guizmaii commented 6 years ago

Hi again @maxpumperla,

Sorry to bother you today 😅

I was reading your code and saw some little things to make more "scalaish".

I can do a lot more but I don't have the time today and it's already a nice PR to review, I think.

Your Move class, because of the way you use it and its doc, could/should be an ADT. It'll make the code more idiomatic to Scala developers and it'll help the Scala compiler to help you more (code more typesafe).

As always, if this contribution doesn't interest you. Just close the PR. It's totally ok to me.

maxpumperla commented 6 years ago

@guizmaii awesome, keep it coming. Invite your friends ;)