`PlayerColor` should be an ADT

maxpumperla / ScalphaGoZero

An independent implementation of DeepMind's AlphaGoZero in Scala, using Deeplearning4J (DL4J)

Apache License 2.0

156 stars 24 forks source link

Closed guizmaii closed 6 years ago

guizmaii commented 6 years ago

You asked for more, this is more :)

(If you merge, can you squash my commits please ?)

maxpumperla commented 6 years ago

@guizmaii awesome, is this ready to go from your side? I'd review then.

guizmaii commented 6 years ago

@maxpumperla I just added a little commit that comes from my next branch.

It adds some JVM options for the sbt run. Without these options, the run fails with an OOM.

It's ready to review ;)

maxpumperla commented 6 years ago

thanks @guizmaii, I was very unhappy with how I handled PlayerColor previously