Compatibility with C9.io

maxpumperla / betago

BetaGo: AlphaGo for the masses, live on GitHub.

http://maxpumperla.github.io/betago

MIT License

680 stars 162 forks source link

Compatibility with C9.io #28

Closed rocketinventor closed 7 years ago

rocketinventor commented 7 years ago

BetaGo now works flawlessly with web IDE's such as C9.io.

Changes:

Change port number from 5000 to 8081
User interface no longer requires localhost (can use any web address)
User interface is automatically hosted at [server root]:8081
Bash script to easily run the demo (once installed)

rocketinventor commented 7 years ago

It's worth noting that due to the way the pull-request is structured, it should be easy to modify the HTML document on the fly (before it reaches the browser) using Python.

Possible uses/abuses for this include "hardcoding" a port number (and/or URL) into the HTML (based on environmental variables) and embedding a list of past moves directly into the HTML (Google Keep works similar to this).

rocketinventor commented 7 years ago

@macfergus Are we good to go for a merge, or are there still changes that need to be made?

macfergus commented 7 years ago

Yes this looks good. Thanks for your contribution!

I do think it will be nice for the port to be configurable, but I will do that in a followup.

rocketinventor commented 7 years ago

Awesome! Thanks for the feedback and merge!