maxpumperla / deep_learning_and_the_game_of_go

Code and other material for the book "Deep Learning and the Game of Go"
https://www.manning.com/books/deep-learning-and-the-game-of-go
953 stars 387 forks source link

Chapter 3 #16

Closed Farreep closed 5 years ago

Farreep commented 5 years ago

Before submitting a pull request, note that master and the respective chapter branches need to stay in sync with the print version of the book.

Should your current PR mix these types of changes, please consider to split it accordingly. Thank you!

8rax commented 3 years ago

Hello, I do not understand why in the book it is explicitely advised to go here and check the code, while the code is different here. Scoring is not part of chapter 3 but it is used in the goboard.py in this branch. Such consistency problems are really annoying and make everything complicated. Having consistent versions of the code per chapter would be helpful. Or did I miss something ?

maxpumperla commented 3 years ago

@8rax I've seen your other issue. Apart from additional code, scoring, is there another instance of "such inconsistencies"?