search

maxpumperla / entropy-mdlp

Minimum description length principle algorithm in Python, for optimal binning of continuous variables
MIT License
59 stars 20 forks source link

Why use a class? #5

Open mhlr opened 3 years ago

mhlr commented 3 years ago

https://github.com/maxpumperla/entropy-mdlp/blob/d8059f3390ed0c4fc0cde212533e436a96771ec7/entropymdlp/mdlp.py#L6

MDLP has no state or data attributes. All the methods could be promoted to module level functions removing the need to create any instance objects and a simpler design

maxpumperla commented 3 years ago

sure, send a PR