maxpumperla / entropy-mdlp

Minimum description length principle algorithm in Python, for optimal binning of continuous variables
MIT License
59 stars 20 forks source link

Simplify module structure and remove print statement #6

Closed el-hult closed 1 year ago

el-hult commented 1 year ago

To avoid instantiating an object (that I don't see any use of), I have removed the class statements, and all occurances of self. This is in accordance with #5, which also asks for a PR.

To avoid printing something that is returned by the function anyways, I have removed the print in the entropy function.

To simplify the import statements, I have reexported all the MDLP functions from the module namespace. Now, you don't need to import from the submodule.

The documentation has ben updated accordingly.

maxpumperla commented 1 year ago

lgtm, thank you!