search

maxrave-dev / SimpMusic

A simple music app using YouTube Music for backend
https://simpmusic.tech/
GNU General Public License v3.0
1.38k stars 95 forks source link

Implement couple local like and YT like functionality #331

Closed Geigerkind closed 1 month ago

Geigerkind commented 1 month ago

Hello, first of all thanks for the app, it is really nice.

When I was using the app, I found it very tedious that I had to like a song separately for YouTube. So I added a opt in functionality to do both using the Heart button.

There are a few open tasks that need to be done before this could be merged, where I need your assistance:

  1. What do I do about the translations for all languages besides the one I am capable of speaking?
  2. I noticed that the updateLikeStatus functionality is used all over the place. The place where I implemented the functionality is the SharedViewModel but this is not used by all views. I was looking for some kind of "UseCase"-Service or somewhere else to put it, any idea what could be a good place?
  3. Also I am unsure of when a likeStatus counts towards an album/artist or song, as I think the YT Like button only works for the latter.

Cheers!

maxrave-dev commented 1 month ago

Like in local and Add to YouTube Liked playlist are two features separately. I think if combined, it's too same with YT Music

Geigerkind commented 1 month ago

I see. Feel free to use the code, whenever you please :) GL!