search

maxrave-dev / SimpMusic

A simple music app using YouTube Music for backend
https://simpmusic.tech/
GNU General Public License v3.0
1.38k stars 95 forks source link

Fix Traditional Chinese resource directory name. #354

Closed eric100lin closed 3 weeks ago

eric100lin commented 3 weeks ago

Update the resource directory of Traditional Chinese according to https://github.com/maxrave-dev/SimpMusic/commit/273c65e214109030938331d9ae18b4e6ce00852d.

maxrave-dev commented 3 weeks ago

No need to do this bro, zh-rTW still works with values directory

eric100lin commented 2 weeks ago

This is required for the app to get Traditional Chinese resources.

maxrave-dev commented 2 weeks ago

No needed, check out latest nightly build

eric100lin commented 2 weeks ago

This PR is necessary for the app to access Traditional Chinese resources. You can test this using per-app language settings. Ensure the resource directory name aligns with the resourceConfigurations specified in your build.gradle.kts file.

Additionally, I'm not seeing Traditional Chinese support from the nightly build badge because it points to the 'dev' branch instead of the 'jetpack_compose' branch. I tried the nightly build downloaded from GitHub Actions, and Traditional Chinese is not working. Please merge this PR, thanks!

eric100lin commented 2 weeks ago

I update the commit to use b+zh+Hant+TW instead of b+zh+Hant, please check the new https://github.com/maxrave-dev/SimpMusic/pull/357.