search

maxrchung / S2VX

yeah it's like osu! but with more squares and motion sickness
https://S2VX.com
MIT License
2 stars 1 forks source link

Fix NotesTimeline visual tests (GUI) #459

Open Xenocidel opened 3 years ago

Xenocidel commented 3 years ago

As a developer, I want to fix the GUI for visual tests so that coordinates/offsets relative to object positions are accurate.

For some resolutions, the NotesTimeline visual tests in the GUI will fail due to the scaling of the DrawSizePreservingFillContainer within the test runner scene.

This may be the same issue as #443

OnToolDrag_DragEndOfTimelineHoldNoteLeft_DoesNotScrollTimelineLeft

maxrchung commented 3 years ago

I looked at this earlier in the week but didn't make much more progress other than what Aaron already looked at. I think that to troubleshoot this further, one thing we can do for ourselves is to setup our S2VX and osu-framework solutions in such a way that we can hook up osu-framework to our running code.