search

maxritter / diy-thermocam

A do-it-yourself thermal imager, compatible with the FLIR Lepton 2.5, 3.1R and 3.5 sensor with Arduino firmware
http://www.diy-thermocam.net
GNU General Public License v3.0
1.12k stars 174 forks source link

Wire.endTransmission() and Wire.beginTransmission() should not be used with Wire.requestFrom(). #24

Closed Koepel closed 6 years ago

Koepel commented 6 years ago

The Wire.endTransmission() after the Wire.requestFrom() and the Wire.beginTransmission() before the Wire.requestFrom() can be removed in the next files:

In "DIY-Thermocam/Firmware/Source/Hardware/Touchscreen/FT6206_Touchscreen.cpp" there is also requesting 32 bytes, but using only 16 bytes.

Explanation: Common-mistakes#2 number 2 and 3.

maxritter commented 6 years ago

Thanks for the information. It's worth mentioning, but I haven't noticed any bugs or issues by using the Wire library in the way it's implemented in the firmware at the moment. That's why I will close this issue until there is a real problem.