search

maxrohleder / AdvancedMI

Contains source code for the Advanced Medical Imaging Seminar in SS 2020. The goal is to conceptualize, prototype and pitch ideas related to clinical communications.
BSD 3-Clause "New" or "Revised" License
1 stars 0 forks source link

remove all warnings at compilation time #19

Open maxrohleder opened 4 years ago

maxrohleder commented 4 years ago

Compiled with warnings.

./src/index.js Line 29:29: Unnecessary escape character: \^ no-useless-escape Line 29:37: Unnecessary escape character: [ no-useless-escape Line 29:41: Unnecessary escape character: \/ no-useless-escape

./src/AdminApp.js Line 29:31: Unnecessary escape character: \^ no-useless-escape Line 29:39: Unnecessary escape character: [ no-useless-escape Line 29:43: Unnecessary escape character: \/ no-useless-escape Line 68:35: Unexpected string concatenation of literals no-useless-concat Line 68:51: Unexpected string concatenation of literals no-useless-concat Line 95:35: Unexpected string concatenation of literals no-useless-concat Line 95:51: Unexpected string concatenation of literals no-useless-concat Line 138:29: Unexpected string concatenation of literals no-useless-concat Line 138:45: Unexpected string concatenation of literals no-useless-concat

./src/components/editAdminInfo.js Line 2:10: 'Redirect' is defined but never used no-unused-vars Line 33:32: Expected '===' and instead saw '==' eqeqeq

./src/components/PatMan.js Line 45:30: Expected '===' and instead saw '==' eqeqeq Line 76:31: Unnecessary escape character: \^ no-useless-escape Line 76:39: Unnecessary escape character: [ no-useless-escape Line 76:43: Unnecessary escape character: \/ no-useless-escape Line 113:9: 'auth' is assigned a value but never used no-unused-vars

./src/components/loginForUser.js Line 46:18: Expected '!==' and instead saw '!=' eqeqeq Line 60:26: Expected '===' and instead saw '==' eqeqeq Line 61:51: Expected '===' and instead saw '==' eqeqeq

./src/components/registerAdmin.js Line 70:31: Unnecessary escape character: \^ no-useless-escape Line 70:39: Unnecessary escape character: [ no-useless-escape Line 70:43: Unnecessary escape character: \/ no-useless-escape Line 96:29: Expected '===' and instead saw '==' eqeqeq

./src/components/loginForAdmin.js Line 81:31: Unnecessary escape character: \^ no-useless-escape Line 81:39: Unnecessary escape character: [ no-useless-escape Line 81:43: Unnecessary escape character: \/ no-useless-escape

./src/PatientApp.js Line 82:30: Expected '===' and instead saw '==' eqeqeq Line 83:17: Expected '===' and instead saw '==' eqeqeq

Search for the keywords to learn more about each warning. To ignore, add // eslint-disable-next-line to the line before.

Karl-Heinrich commented 4 years ago

Instead of ignoring these warning, why don't we fix them instead?

Especially something like Line 82:30: Expected '===' and instead saw '==' eqeqeq can get us into real trouble. In Javascript, 1 == '1' will be true, even though these two variables have different types, whereas 1 === '1' is false, which is the expected behavior.