search

maxrohleder / AdvancedMI

Contains source code for the Advanced Medical Imaging Seminar in SS 2020. The goal is to conceptualize, prototype and pitch ideas related to clinical communications.
BSD 3-Clause "New" or "Revised" License
1 stars 0 forks source link

move css into components #26

Open maxrohleder opened 4 years ago

maxrohleder commented 4 years ago

As many sources showed the code becomes better maintainable when the css is at the component

This requires the refactoring of the Login, login, loginForUser... components into a single component with conditional styles and routing behaviour.

Karl-Heinrich commented 3 years ago

I am not sure why you would want to refactor those components into a single one. We could just use a css file for each component or use css.modules. We could also use JS Objects, CSS in JS or add a styling library.

maxrohleder commented 3 years ago

General design question. Lets talk about this; you are the expert.

Those logins should all look the same. Currently, wanting to make a slight change to that look results in having to change several files....