maxrossello / redmine_app_timesheets

A true timesheet plugin using orders, not bound to timelogs over issues
GNU General Public License v2.0
32 stars 10 forks source link

Redmine 3.0 Compatibility #45

Closed greyman888 closed 9 years ago

greyman888 commented 9 years ago

Hi,

Our organisation would like to move to Redmine 3.0 and I was wondering if you have any plans to make your timesheet plugin compatible?

I've set up a Redmine 3.0 development environment (config at the bottom) and installed:

Here are the results so far:

app__space

Appears to work without errors

Orders

ActiveRecord::StatementInvalid in Projects#settings
PG::SyntaxError: ERROR:  subquery has too many columns
LINE 2: ...(versions.project_id != 2 AND versions.project_id IN (SELECT...
<snip>

Timesheet

ArgumentError in TimesheetsController#index
    Support for calling #default_scope without a block is removed. For example instead of default_scope where(color: 'red')`, please use `default_scope { where(color: 'red') }`. (Alternatively you can just redefine self.default_scope.)

Spent Time - Details Tab

**Spent Time - Report Tab***

ArgumentError in Timelog#report
"Support for calling #default_scope without a block is removed. For example instead of `default_scope where(color: 'red')`, please use `default_scope { where(color: 'red') }`. (Alternatively you can just redefine self.default_scope.)"

Environment: Redmine version 3.0.0.devel Ruby version 2.1.5-p273 (2014-11-13) [x86_64-linux] Rails version 4.2.0 Environment development Database adapter PostgreSQL

SCM: Subversion 1.8.8 Mercurial 2.8.2 Cvs 1.12.13 Bazaar 2.7.0 Git 1.9.1 Filesystem

Redmine plugins: redmine_app__space 1.0.3 redmine_app_timesheets 1.4.12

maxrossello commented 9 years ago

Hi Adam, unfortunately we are not shifting to Redmine 3.0 so soon, and currently I am still very busy after another project. I will get into it ASAP.

You detailed test is very useful and will help a lot, thank you!

greyman888 commented 9 years ago

I understand. When you do get into it, please let me know if there is a way I can help. On 27/02/2015 10:41 PM, "maxrossello" notifications@github.com wrote:

Hi Adam, unfortunately we are not shifting to Redmine 3.0 so soon, and currently I am still very busy after another project. I will get into it ASAP.

You detailed test is very useful and will help a lot, thank you!

Reply to this email directly or view it on GitHub https://github.com/maxrossello/redmine_app_timesheets/issues/45#issuecomment-76382393 .

maxrossello commented 9 years ago

Please find new branch 1.5-dev. It should be compatible with Redmine 3.0 and backward compatible as well. As this branch turns to be considered stable, I will split a 1.4_stable branch from master and merge 1.5-dev to master.

Closing this issue as I expect new issues to be opened for each specific problem. Thank you!

greyman888 commented 9 years ago

Thank you. That was very fast!

I will start some testing today.

maxrossello commented 9 years ago

Yeah, no rocket science there, so I found some time to accomplish :-)