maxrossello / redmine_extended_watchers

Grant additional issue and project view permissions to watcher users
GNU General Public License v3.0
44 stars 20 forks source link

Extended watchers for Redmine 5.0.6 #49

Closed miguelpalma81 closed 10 months ago

miguelpalma81 commented 10 months ago

Hello, first of all I want to congratulate you on your great work. I'm trying to install Wachers Extender 5.0.2 but in redmine 5.0.6 it gives an error. Any predictions for compatibility for redmine 5.0.6? Thank you.

maxrossello commented 10 months ago

Version 5.0.2 fits Redmine 5.0.6. Please check possible conflicts with other plugins that you may have installed and, if after removing every other plugin it still gives an error, report more details here

miguelpalma81 commented 10 months ago

Hello, thank you for your quick reply. I found conflict with the People plugin (https://www.redmineup.com/pages/plugins/people), uninstalled it and it worked. But I need this plugin. I'll send the log if I can help with the compatibility between these two plugins working together in redmine.

Thank you very much.

Log: ==> log/production.log <== [202afdd3-f7bf-433f-a2e5-67ae2bfadede] plugins/redmine_extended_watchers/lib/extended_watchers_user_patch.rb:23:in allowed_to?' [202afdd3-f7bf-433f-a2e5-67ae2bfadede] plugins/redmine_people/lib/redmine_people/patches/user_patch.rb:83:inpublic_send' [202afdd3-f7bf-433f-a2e5-67ae2bfadede] plugins/redmine_people/lib/redmine_people/patches/user_patch.rb:83:in block in <module:InstanceMethods>' [202afdd3-f7bf-433f-a2e5-67ae2bfadede] plugins/redmine_extended_watchers/lib/extended_watchers_user_patch.rb:23:inallowed_to?' [202afdd3-f7bf-433f-a2e5-67ae2bfadede] plugins/redmine_people/lib/redmine_people/patches/user_patch.rb:83:in public_send' [202afdd3-f7bf-433f-a2e5-67ae2bfadede] plugins/redmine_people/lib/redmine_people/patches/user_patch.rb:83:inblock in ' [202afdd3-f7bf-433f-a2e5-67ae2bfadede] plugins/redmine_extended_watchers/lib/extended_watchers_user_patch.rb:23:in allowed_to?' [202afdd3-f7bf-433f-a2e5-67ae2bfadede] app/models/issue.rb:915:invisible_journals_with_index' [202afdd3-f7bf-433f-a2e5-67ae2bfadede] app/controllers/issues_controller.rb:96:in show' [202afdd3-f7bf-433f-a2e5-67ae2bfadede] lib/redmine/sudo_mode.rb:61:insudo_mode'

maxrossello commented 10 months ago

Hi, unfortunately the possibility of conflict among plugins is a major issue with Redmine and I can't provide compatibility with every plugin. Even worse, the automated test suites fail when some plugin modifies a behavior that was intended to be tested under a different scope.

For this reason I developed https://github.com/maxrossello/redmine_testsuites which allows to execute the whole suite of regression tests adapted to a bunch of (possibly installed or not) plugins, which are thus proven to work fairly together. I cannot provide support for any other plugin, but I can accept new submissions as merge requests and collaborate with other plugins' developers as long as they apply to this solution.

Regarding your log, it seems that the offending plugin is overwriting the allowed_to? method as well, but I can't tell what is wrong with that

miguelpalma81 commented 10 months ago

Hi,

Thank you for the answer. Therefore, I'm going to remove the people plugin.

Thanks for the help.

maxrossello commented 10 months ago

You're welcome!