maxrossi91 / moni

MONI: A Pangenomic Index for Finding MEMs
MIT License
35 stars 9 forks source link

Cannot install Moni on Debian #3

Closed brunelloandrea closed 11 months ago

brunelloandrea commented 11 months ago

Hello,

I am having some troubles installing Moni on Debian GNU/Linux 10 (buster). gcc/g++ version: 8.3.0 clang version: 7.0.1-8+deb10u2 (tags/RELEASE_701/final) cmake version: 3.25.2

I am cloning the repository, then creating the build directory inside "moni" and, from within "build", running "cmake ..". Then, I get the following warnings:

which I assume I can ignore, being on Linux. Then I also get:

which again do not seem to be critical, since the process terminates without errors.

Then, I run make, again from the "build" directory, but here I get the error: /moni/build/_deps/pfp_thresholds-src/include/pfp/dictionary.hpp:104:22: error: ‘max’ was not declared in this scope auto lcp_right = max(a_in_sa, b_in_sa); ^~~ If I try to correct it modifying dictionary.hpp, for instance adding "std::" before max, I then get some other errors pertaining to the usage of constant expressions in other files, which I cannot solve... but I assume this is not the correct way to proceed.

Could you help me with this issue?

Thank you!

Andrea

maxrossi91 commented 11 months ago

Hi, Andrea,

Thank you for reporting this. If you need only to run MONI, you could try to install it from the release assets. We have three ways to install from there, i.e, using

For the error, I think I may have an idea on where it comes from. The inability of using max was an issue in gsa-is that was fixed by this PR (https://github.com/felipelouza/gsa-is/commit/1a8044df6de57d75e0e45b22720c2cf04b46b9bf). You can try setting the version of gsa-is to 9b229580bea671db24e68f476e6f5d2a5a6360dd in https://github.com/maxrossi91/moni/blob/ffdb1af54ae5673f2def5231c8afedac64a4cebf/thirdparty/CMakeLists.txt#L55 as GIT_TAG 9b229580bea671db24e68f476e6f5d2a5a6360dd. This might solve the issue. (Note that if you do that, you may want to delete the whole build folder and restart from scratch, to ensure cmake downloads the correct version of the repo.)

Bests,

Max

brunelloandrea commented 11 months ago

Great, the .sh file worked like a charm... thank you, Max!

Andrea