maxrousseau / pfla

pfla: Python Facial Landmark Analysis
https://pfla.readthedocs.io/en/master/?badge=master#
MIT License
5 stars 2 forks source link

JOSS - Incomplete Software Paper #6

Closed mnarayan closed 6 years ago

mnarayan commented 6 years ago

Hello,

Some enhancements to https://github.com/maxrousseau/pfla/blob/master/paper/paper.md are needed.

Can you also provide a laymen's description of what types of inputs/outputs your toolbox provides? Despite knowing something about statistical shape analysis, I'm not able to follow exactly what the software can do for me. If you can add a small figure, even better! Some important information is buried in the middle. On pg. 2 you describe M_patient and V_patient. I would try to make this section even simpler/clearer.

Can you add references to the specific solvers and algorithms used for Generalized Procrustes Analysis in your software? Fix the references for Dryden 2017 to point to the specific package url https://cran.r-project.org/web/packages/shapes/shapes.pdf

And the corresponding book that discusses the algorithms e Dryden, I.L. and Mardia, K.V. (2016). Statistical shape analysis, with Applications in R (2nd Edition), John Wiley and Sons.

maxrousseau commented 6 years ago

Thank you for your feedback.

I have:

Let me know if those modifications were satisfactory.

Thank you

mnarayan commented 6 years ago

Much more readable! This is good.