maxs15 / react-native-modalbox

A <Modal/> component for react-native
MIT License
2.89k stars 505 forks source link

removes fixed height for dynamic content #307

Closed andyNroses closed 4 years ago

andyNroses commented 4 years ago

Hey all,

We're using this cool lib in our app, but unfortunately we've been struggling with dynamic content. So we have a bottom modal in which the children height is variable depending on external data. I didn't manage to find a way to customise the styles to handle that, seems like it's either fixed height or full screen basically. So I'm not sure if this change is correct, but everything seems to work fine when we do this, the modal adapts to the height and still behave correctly.

If there is another way to do this without changing the code, I'm all ears.

Thanks, Andy