search

maxs15 / react-native-screcorder

A <Recorder /> element for react-native
233 stars 56 forks source link

recorder keeps appending new instances to page when using a navigator #31

Closed faceyspacey closed 8 years ago

faceyspacey commented 8 years ago

I'm using a Navigator, specifically Ex-Navigator, and when I push a scene that has screcorder on it, and then pop the route, and then push the screcoder scene again, it overlays another version of it. I've tested replacing the Recorder component with a View component and that doesn't happen.

It's the weirdest thing. I tested logging mounting and unmounting and it's getting unmounted. So I don't understand how it renders 2 versions of the Recorder component and its children.

maxs15 commented 8 years ago

Hi @faceyspacey, I'm sorry but I'm not really active on this repo anymore since I aborted my project using screcorder. Since it looks like you're invested in a project using screcorder, would you be interested in being a collaborator ? You would have full control to push your fixes and make this component great again ! Let me know :)

faceyspacey commented 8 years ago

actually I forget what happened, but it ended up being an easy fix. You're right, I am invested, and any problems I encounter I'd be more than willing to push fixes for, but I haven't had any in a while. That said, I'm about to revisit the video recording portion of the app again, so that could change very soon. Overall, it's been a breeze to work with. The biggest thing in the future I'm going to need is an Android version. It looks like I'm going to have to use something else, but making it share the same API is something I'll be able to invest time into. Not sure if we create a new repo that includes them both or what...

maxs15 commented 8 years ago

Great 👍 I'm going to add you as a collaborator in case you need to fix anything.

Well this component is based on SCRecorder which is unfortunately a Library only available for IOS... IMHO the best would be to develop a SCRecorder for Android (on a separate repo), some people are interested in an Android port in the SCrecorder issues (https://github.com/rFlex/SCRecorder/issues/28), I'm sure it would be very successful if you would open-source the project. Then you would have to include your library in react-native-screcorder in order to create the bridge with RN.