maxs15 / react-native-spinkit

A collection of animated loading indicators for React Native
MIT License
2.36k stars 300 forks source link

Add the sageExtGet function to adapt custom version of buildTools, compileSdk and targetSdk #115

Closed panda8z closed 5 years ago

panda8z commented 5 years ago

Add the sageExtGet function to adapt custom version of buildTools, compileSdk and targetSdk

azai91 commented 5 years ago

can this be merged? addresses PR https://github.com/maxs15/react-native-spinkit/issues/104 and https://github.com/maxs15/react-native-spinkit/issues/109

panda8z commented 5 years ago

can this be merged? addresses PR #104 and #109

yes same problem they should use API 28

gtaylor44 commented 5 years ago

Same issue. Can this be merged?

gtaylor44 commented 5 years ago

Another way to get around this issue and have code in source control is to update android\build.gradle under 'allProjects' section to force comipler to use later versions:

    subprojects {
        afterEvaluate {
            project ->
                if (project.hasProperty("android")) {
                    android {
                        compileSdkVersion = rootProject.compileSdkVersion
                        buildToolsVersion = rootProject.buildToolsVersion
                    }
                }
        }
    }
panda8z commented 5 years ago

Another way to get around this issue and have code in source control is to update android\build.gradle under 'allProjects' section to force comipler to use later versions:

    subprojects {
        afterEvaluate {
            project ->
                if (project.hasProperty("android")) {
                    android {
                        compileSdkVersion = rootProject.compileSdkVersion
                        buildToolsVersion = rootProject.buildToolsVersion
                    }
                }
        }
    }

well, but in this way minSDK and targetSDK can not be replace with custom.

panda8z commented 5 years ago

Same issue. Can this be merged?

yes it can be merged

maxs15 commented 5 years ago

Thanks ! Going to merge it, everything looks good

reza7rm commented 5 years ago

Thanks ! Going to merge it, everything looks good

still not working in 1.3.0