maxs15 / react-native-spinkit

A collection of animated loading indicators for React Native
MIT License
2.36k stars 300 forks source link

Switch 'compile' to 'implementation' #120

Closed tethridge closed 5 years ago

tethridge commented 5 years ago

This is a fix for the warning message shown when syncing Gradle. The warning is:

WARNING: Configuration 'compile' is obsolete and has been replaced with 'implementation' and 'api'. It will be removed at the end of 2018.

See: https://github.com/maxs15/react-native-spinkit/issues/119

Xesme commented 5 years ago

Can this be merged in? I am experiencing this issue as well.

hansfpc commented 5 years ago

Nice

majid-vaghari commented 5 years ago

No updates? :-?

andrewsadowski commented 5 years ago

It would be super great if this PR could be merged in. Hitting this problem as well.

cxrod commented 5 years ago

Please @maxs15 can you merge this and bump a new npm version?

GreanBeetle commented 5 years ago

Any chance this will be merged soon?

maxs15 commented 5 years ago

Thanks @tethridge 👍