maxs15 / react-native-spinkit

A collection of animated loading indicators for React Native
MIT License
2.36k stars 300 forks source link

`Spinkit` has no propType for native prop `RNSpinkit.nativeID` #61

Closed Amurmurmur closed 7 years ago

Amurmurmur commented 7 years ago

RN v0.45 Spinkit v1.0.2 Android 7.0

After upgrading to RN v0.45 and build tools 25.0.2 and compileSdk to 25 in build.grandle

The following error started to appear on android:

`Spinkit` has no propType for native prop `RNSpinkit.nativeID` of native type `String`
If you haven't changed this prop yourself, this usually means that your versions of the native code and JavaScript code are out of sync. Updating both should make this error go away.
verifyPropTypes
    verifyPropTypes.js:67:22
requireNativeComponent
    requireNativeComponent.js:108:6
<unknown>
    index.js:54:35
loadModuleImplementation
    require.js:174:12
guardedLoadModule
    require.js:126:36
_require
    require.js:110:24
<unknown>
    index.js:86:22
loadModuleImplementation
    require.js:174:12
guardedLoadModule
    require.js:126:36
_require
    require.js:110:24
<unknown>
    Navigator.js:29
loadModuleImplementation
    require.js:174:12
guardedLoadModule
    require.js:126:36
_require
    require.js:110:24
<unknown>
    NavigatorView.js:5
loadModuleImplementation
    require.js:174:12
guardedLoadModule
    require.js:126:36
_require
    require.js:110:24
<unknown>
    NavigatorViewContainer.js:2
loadModuleImplementation
    require.js:174:12
guardedLoadModule
    require.js:126:36
_require
    require.js:110:24
<unknown>
    index.js:13
loadModuleImplementation
    require.js:174:12
guardedLoadModule
    require.js:126:36
_require
    require.js:110:24
<unknown>
    index.android.js:10
loadModuleImplementation
    require.js:174:12
guardedLoadModule
    require.js:119:45
_require
    require.js:110:24
global code

Here is the screenshot:

screen shot 2017-06-08 at 03 13 56

Seems the problem is only on the android platform.

Thank you in advance!

miphik commented 7 years ago

+1

jayce712 commented 7 years ago

+1

Exilz commented 7 years ago

I opened a PR for this

62

ghost commented 7 years ago

@Exilz thanks it's working now !

Amurmurmur commented 7 years ago

@Exilz So quick fix! Thank you so much! Its all cool 👍

jkomyno commented 7 years ago

@maxs15 @Exilz this is happening for me again with react-native@0.46.1

HappyToper commented 7 years ago

var iface = { name: 'ImageView', propTypes: { src: PropTypes.string, borderRadius: PropTypes.number, resizeMode: PropTypes.oneOf(['cover', 'contain', 'stretch']), ...View.propTypes // include the default view properties }, };