search

maxs15 / react-native-spinkit

A collection of animated loading indicators for React Native
MIT License
2.36k stars 300 forks source link

Remove <application> from AndroidManifest #95

Closed KELiON closed 3 years ago

KELiON commented 6 years ago

<application> in description makes harder to customize it for application. I.e. we are using react-native-config to store all values in one .env file and we customize application name with ENV-variable called DISPLAY_NAME. For this we use next code in AndroidManifest.yml:

<application
      android:name=".MainApplication"
      android:label="@string/DISPLAY_NAME"
      ...

In this case there is a conflict with AndroidManifest.yml from react-native-spinkit package, because android:label is different in main manifest and local package manifest.

Would be better to remove this tag from AndroidManifest.yml in your package and add wiki instruction to add android:supportsRtl="true" in main AndroidManifest.yml.

KELiON commented 6 years ago

Attaching error during build of android app:

Attribute application@label value=(@string/DISPLAY_NAME) from AndroidManifest.xml:23:7-43
        is also present at [appbonus:react-native-spinkit:unspecified] AndroidManifest.xml:12:9-41 value=(@string/app_name).
        Suggestion: add 'tools:replace="android:label"' to <application> element at AndroidManifest.xml:20:5-51:19 to override.
maxs15 commented 3 years ago

Your PR is old but I guess it's never too late 🙂