search

maxs15 / react-native-spinkit

A collection of animated loading indicators for React Native
MIT License
2.36k stars 300 forks source link

update android/build.gradle #98

Closed zeayal closed 3 years ago

zeayal commented 5 years ago

Fix error during the build the projects.

Execution failed for task ':react-native-spinkit:verifyReleaseResources'.
> com.android.ide.common.process.ProcessException: Failed to execute aa

image

JakeRawr commented 5 years ago

It would help a lot if we can merge this soon

JakeRawr commented 5 years ago

Actually, can we change this PR to use

def safeExtGet(prop, fallback) {
    rootProject.ext.has(prop) ? rootProject.ext.get(prop) : fallback
}

android {
    compileSdkVersion safeExtGet('compileSdkVersion', 26)
    buildToolsVersion safeExtGet('buildToolsVersion', '27.0.3')
     defaultConfig {
        minSdkVersion safeExtGet('minSdkVersion', '23')
        targetSdkVersion safeExtGet('targetSdkVersion', '26')
        versionCode 1
        versionName "1.0"
    }
mvanroon commented 5 years ago

last commit was over a year ago :) I think your best bet it to use/fork zeayal:master's branch