search

maxsaltonstall / letters-with-strangers

Apache License 2.0
2 stars 0 forks source link

Fix duplicate vowels #172

Open davidstanke opened 3 years ago

davidstanke commented 3 years ago

image

Looks like it's possible to get duplicates from getvowel

Wyatt-Stanke commented 3 years ago

What if you have A, E, I, O, and U and then run getvowel?

maxsaltonstall commented 3 years ago

It should probably fail. Seems like a good edge case to consider, but no game reason to request a vowel at that point.

On Mon, Sep 6, 2021 at 8:38 AM Wyatt Stanke @.***> wrote:

What if you have A, E, I, O, and U and then run getvowel?

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/maxsaltonstall/letters-with-strangers/issues/172#issuecomment-913616916, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACYFMMKOPTG5FYUKCAP4A3TUASY2TANCNFSM5DCSDZSQ . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

Wyatt-Stanke commented 3 years ago

But some words have two of the same vowels.

maxsaltonstall commented 3 years ago

You don't need a letter twice to use it two, three or fifty times in a word.

Wyatt-Stanke commented 3 years ago

Oops! Sorry, forgot about that :P