search

maxsokolov / TableKit

Type-safe declarative table views.
MIT License
706 stars 74 forks source link

Improve Generic parameters #45

Closed OdNairy closed 8 years ago

OdNairy commented 8 years ago

Hi there In #42 where an interesting improvement by reusing CellType.ItemType generic. Would you add this one into repo? Can I help you with PR for that? May be @noxt want to make it first?

maxsokolov commented 8 years ago

Hi @OdNairy,

I'm personally really love this improvement. So it's all depends on my team's vision on this.

The case is that this TableRow<String, StringTableViewCell>(item: "1") is more informative than this TableRow<StringTableViewCell>(item: "1"). When you have really big and difficult tableviews with lots of cells it could actually help to understand what happening in your tableview a bit faster. But I think it is the discussable moment. Guys from my team currently prefer more informative variant.

But I will try to push forward the improvement.

maxsokolov commented 8 years ago

Glad to inform that I've got an approval from my team. After some discussion we've decided that this is actually good change that makes this library even better.

I also have to thank the community which pointed attention on this change several times.

maxsokolov commented 8 years ago

So, new changes are also available via Cocoapods, version 2.0.0. @OdNairy thanks for correcting me with semver.