maxsokolov / TableKit

Type-safe declarative table views.
MIT License
706 stars 74 forks source link

Dynamic cell height based on configured item #61

Open Wisors opened 7 years ago

Wisors commented 7 years ago

Issue: some cell might have different static heights for each state of item. As a result now, I have to create a two copies of cell with different heights, because cell class only has ability to return it height from the static variable. I know I can use AutoLayout, but it actually much slower and I need to improve performance here. I propose to deprecate this static variables:

    static var defaultHeight: CGFloat? { get }
    static var estimatedHeight: CGFloat? { get }

And replace it with instance functions:

    func estimatedHeight(with _: T) -> CGFloat?
    func heigth(with _: T) -> CGFloat?

With this approach it is still possible to return static value, but in the same time much more flexible for user.

sashkyn commented 6 years ago

+1

Banck commented 6 years ago

@maxsokolov Hey! Is it possible to add this feature? Thanks!

maxsokolov commented 6 years ago

Hey @Banck I don't have plan for this in the near future.