Ft multi robots - Githubissues

maxspahn / gym_envs_urdf

URDF environments for gym

https://maxspahn.github.io/gym_envs_urdf/

GNU General Public License v3.0

46 stars 14 forks source link

Ft multi robots #122

Closed maxspahn closed 2 years ago

maxspahn commented 2 years ago

Introduces changing the structure to one single environment with given robot instances. That also allows having multiple robots in parallel. Refer to #120 for more information.

lgtm-com[bot] commented 2 years ago

This pull request introduces 1 alert and fixes 14 when merging 769e37a28e951f018e77888e1eabf9088b51b7c7 into 29dcf413664ebf40bc6d6b7db4ec6317c4f7d992 - view on LGTM.com

new alerts:

1 for Wrong number of arguments in a call

fixed alerts:

14 for Unused import

lgtm-com[bot] commented 2 years ago

This pull request introduces 1 alert and fixes 14 when merging e06e2c85bc8ff45cab167e617f4b41a386c77d2b into 29dcf413664ebf40bc6d6b7db4ec6317c4f7d992 - view on LGTM.com

new alerts:

1 for Wrong number of arguments in a call

fixed alerts:

14 for Unused import

c-salmi commented 2 years ago

The test still fails at the obstacle sensor part. However it only fails when running all tests at the same time. Locally running just pytest test_obstacle_sensor.py does work, not sure what causes this.

lgtm-com[bot] commented 2 years ago

This pull request introduces 1 alert and fixes 14 when merging 5c8944150729acec473670a8a2f62d132751489b into 29dcf413664ebf40bc6d6b7db4ec6317c4f7d992 - view on LGTM.com

new alerts:

1 for Wrong number of arguments in a call

fixed alerts:

14 for Unused import

lgtm-com[bot] commented 2 years ago

This pull request introduces 1 alert and fixes 15 when merging b2ac12d96312db2f17fa551cdf3f609dcae5ca9a into 29dcf413664ebf40bc6d6b7db4ec6317c4f7d992 - view on LGTM.com

new alerts:

1 for Wrong number of arguments in a call

fixed alerts:

14 for Unused import
1 for Unused local variable

maxspahn commented 2 years ago

@c-salmi Now, it seems fine.

maxspahn commented 2 years ago

We should still improve the warning when the observation is outside the observation space. It should indicate which robot is the one causing the problem. You can run the multi_robot example to see the confusing behavior.

lgtm-com[bot] commented 2 years ago

This pull request introduces 1 alert and fixes 15 when merging 6eed4881459abc9f05b2e4a9dc45cb83e8d9c24c into 29dcf413664ebf40bc6d6b7db4ec6317c4f7d992 - view on LGTM.com

new alerts:

1 for Wrong number of arguments in a call

fixed alerts:

14 for Unused import
1 for Unused local variable

lgtm-com[bot] commented 2 years ago

This pull request introduces 1 alert and fixes 15 when merging e57117fe0c17befa49e968068797f1037ceee7b6 into 29dcf413664ebf40bc6d6b7db4ec6317c4f7d992 - view on LGTM.com

new alerts:

1 for Wrong number of arguments in a call

fixed alerts:

14 for Unused import
1 for Unused local variable

maxspahn commented 2 years ago

@c-salmi: Could you add an example with the panda robot without the gripper. The naming seems to be causing confusion as there is already a panda robot in the pybullet_data package.

lgtm-com[bot] commented 2 years ago

This pull request introduces 1 alert and fixes 17 when merging 6e9bd43165c69d3dc8f32610222a3efe7b3a2b44 into 29dcf413664ebf40bc6d6b7db4ec6317c4f7d992 - view on LGTM.com

new alerts:

1 for Wrong number of arguments in a call

fixed alerts:

14 for Unused import
2 for Unnecessary pass
1 for Unused local variable

lgtm-com[bot] commented 2 years ago

This pull request introduces 1 alert and fixes 17 when merging affa1cd9d9aa9802132f7008710d778ef05c4011 into 29dcf413664ebf40bc6d6b7db4ec6317c4f7d992 - view on LGTM.com

new alerts:

1 for Wrong number of arguments in a call

fixed alerts:

14 for Unused import
2 for Unnecessary pass
1 for Unused local variable