search

maxspahn / gym_envs_urdf

URDF environments for gym
https://maxspahn.github.io/gym_envs_urdf/
GNU General Public License v3.0
43 stars 14 forks source link

Updates in sensor #223

Closed maxspahn closed 1 year ago

maxspahn commented 1 year ago

Hello Max. I saw some improvements made on sensor but didn't have time to check the code and the commits. Could you please elaborate that what was the issue and what's being fixed right now? Because I didn't see any issues in tests that I've made and right now I'm able to train the RL agent (but failing to find a place to run the code. 😅).

Thanks.

_Originally posted by @behradkhadem in https://github.com/maxspahn/gym_envs_urdf/issues/222#issuecomment-1674493227_

maxspahn commented 1 year ago

What is the state at which you are? Only then, I can tell you what has changed. However there is also the CHANGELOG.md on the individual releases.

Let me know what exactly your state/question is.

behradkhadem commented 1 year ago

What is the state at which you are? Only then, I can tell you what has changed. However there is also the CHANGELOG.md on the individual releases.

Let me know what exactly your state/question is.

I don't know what you mean by "the state" but I'm using the position of the panda robot arm to perform pick and place. And I obtain the position of the obstacle via the Full sensor.

maxspahn commented 1 year ago

That hasn't changed recently. So it should be safe for you :wink:

behradkhadem commented 1 year ago

That hasn't changed recently. So it should be safe for you 😉

Pew! Thanks! 😅😅

BTW, where can I ask my questions about the package? This package doesn't have discussions, and questions are not issues. And I see that you are meticulous about this, so I wanted to know your preference on this matter.

Thanks.

maxspahn commented 1 year ago

BTW, where can I ask my questions about the package? This package doesn't have discussions, and questions are not issues. And I see that you are meticulous about this, so I wanted to know your preference on this matter.

Good point. I added a discussion now, see https://github.com/maxspahn/gym_envs_urdf/discussions