maxsu / IFProject

GNU Affero General Public License v3.0
0 stars 1 forks source link

Main isn't up to date #7

Closed exfret closed 7 months ago

exfret commented 7 months ago

I notice we have not put main up to date with the most recent work on the parser. My understanding is that the parser is in a workable state now, so a pull request should be started that I can review and accept. (We've already gone through the code so I would just accept, but I think this is good practice, right?). The interpreter is sort of a different feature and either needs its own branch or needs main to be updated with that pull request.

maxsu commented 7 months ago

Sorry, I missed this until now!

I reviewed and extended your nodes in the Add Nodes branch. I got all stories testing green! I observed the approach was much simpler than my code, so I discarded the cursed prototype. I saved the tests and fixtures - I'll add them back to the project as we add the nodes.

Now that our AST tests are passing (for a subset of nodes), I think it makes sense to start working on the step functions. I have rebased the game loop PR onto your work plus my extensions.

I think we should start designing the step functions and test fixtures needed to support the story yaml scenarios (starting with hello world).

maxsu commented 7 months ago

Closing the issue. Stay tuned for PRs!