maxsupermanhd / FactoCord-3.0

Factorio bidirectional Discord bridge bot for Linux servers with control functionality.
Apache License 2.0
14 stars 10 forks source link

[BUG] Restart command existing #32

Closed Galapagon closed 4 years ago

Galapagon commented 4 years ago

BUG-FILTER-CHECKLIST. Anyone who opens up a bug report must fill these checkboxes (add an "x" to [ ] to be like [x]) to assume that he acknowledged that he red README.md and followed checklist below.

Describe the bug Messages are inconsistant and in some instances sending too many messages.

To Reproduce $restart sends Four messages, $stop sends a different message

Expected behavior Restart should probably only send two messages. :Recycle: Saved server, now restarting! Definately NOT :octagonal_sign: The server has stopped!

Server restarted successfully! -OR- white_check_mark Galapagon.freemyip.com:34198 (June Base) has started! Restart message seems to send before server is ready for clients to connect though.

$stop is also sending a 3rd different message at this time Server saved and shutting down; Cya! Should probably be :octagonal_sign: The server has stopped! since that is what is in .env

My instance information

TechnoStrife commented 4 years ago

restart is bugged at the moment as it doesn't wait for factorio to exit and starts a new instance that refuses to run because previous one hasn't exited. I will probably just remove those not-configurable messages because they're about what the bot is doing rather than what factorio is doing

Galapagon commented 4 years ago

I just ran restart on my server and it was able to restart properly could be because the server was still in the initial waiting state