search

maxtaco / icsify

browserify v2 plugin to compile coffee-script automatically
Other
5 stars 0 forks source link

conflicts with coffee-ify #1

Open andrewrk opened 11 years ago

andrewrk commented 11 years ago

I'm trying to make it so that users of my app can use coffeescript, javascript, coco, livescript, or iced-coffee-script. Here's how I've done this: https://github.com/superjoe30/chem-cli/blob/0c50be9c910c9a601b551d35bd78825209e52aa5/index.js#L236

I enable all the "ify" filters, and then each one checks for its own file extension and does the compiling if necessary.

The problem is that both coffee-ify and icsify both try to parse .coffee files, which results in the files being compiled twice, which does not work.

The cleanest way I see to solve this for both of our projects would be to remove the filtering for .coffee and .litcoffee files from icsify, and then in your project, if you want to also compile .coffee files, add the coffee-ify filter to your toolchain.

Thoughts?

maxtaco commented 11 years ago

Does it work if you don't run coffeeify at all, and just run icsify?

andrewrk commented 11 years ago

No - because part of my definition of "working" is that .coffee files are compiled with the official coffee-script compiler.

maxtaco commented 11 years ago

Hah, so you and I have different versions of 'working' :) Out of curiosity, are there CoffeeScript features that are broken in ICS? If so, I should definitely fix them.

andrewrk commented 11 years ago

Not that I know of. I'll let you know if I find any.