maxtance / pe

0 stars 0 forks source link

Wrong error message for wrong parameter name #6

Open maxtance opened 1 year ago

maxtance commented 1 year ago

Input: prof n/Koro Sensei m/CS3230 p/98663357 e/KoroSensei@gmail.com g/M t/wanted gitt/senseikoro

Expected error message: Invalid command format / Invalid parameter

Actual error message: Tags names should be alphanumeric

Screenshot 2022-11-11 at 5.05.49 PM.png

nus-pe-bot commented 1 year ago

Team's Response

The prefix for the GITHUB_USERNAME is git/ not gitt/ as the tester has attempted.

This means the tag inputted is wanted gitt//senseikoro which has non-Alphanumeric characters, and so the error message is actually correct.

Items for the Tester to Verify

:question: Issue response

Team chose [response.Rejected]

Reason for disagreement: A functionality bug includes behaviours the differ from normal expectations. In this scenario, my tag is wanted and my prefix is gitt/. My tag is valid as it only contains alphanumeric characters while my prefix is incorrect as it should be /git (as mentioned in the team's response). Hence, the error message should be about the wrong prefix used instead of an invalid tag.

To further illustrate my point, the error given by using sort A-Z nm/ is appropriate in this case (see figure below). This is understandably a limitation of most of our applications as it was how AB3 implemented the parser. It will bring minor inconvenience to users as users can manually identify the error, hence a low severity was given.

Screenshot 2022-11-16 at 9.58.44 AM.png